Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmtp: fix sha #105170

Merged
merged 1 commit into from Nov 27, 2020
Merged

libmtp: fix sha #105170

merged 1 commit into from Nov 27, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 27, 2020 •
edited

Motivation for this change

incorrectly added in c75b9da #104000

hash mismatch in fixed-output derivation '/nix/store/x8zj5b5kjb6r4m7zpkpv9bm1f39y8z3j-source':
  wanted: sha256:0lniy0xq397zddlhsv6n4qjn0wwakli5p3ydzxmbzn0z0jgngjja
  got:    sha256:0rya6dsb67a7ny2i1jzdicnday42qb8njqw6r902k712k5p7d1r9
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
libmtp: fix sha
d4dd72e 
incorrectly added in c75b9da

```
hash mismatch in fixed-output derivation '/nix/store/x8zj5b5kjb6r4m7zpkpv9bm1f39y8z3j-source':
  wanted: sha256:0lniy0xq397zddlhsv6n4qjn0wwakli5p3ydzxmbzn0z0jgngjja
  got:    sha256:0rya6dsb67a7ny2i1jzdicnday42qb8njqw6r902k712k5p7d1r9
```
@jonringer jonringer requested a review from nh2 November 27, 2020 19:23
@jonringer
Copy link
Contributor Author

this was in the logs for changes as well: https://logs.nix.ci/?key=nixos/nixpkgs.104000&attempt_id=799e59b9-0284-4258-9506-b601c8988b1a

nh2
nh2 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I must have somehow screwed up the version after testing the switch to the repo with an earlier release. This one checks out for me as well.

@nh2 nh2 merged commit 5f59830 into NixOS:staging Nov 27, 2020
@jonringer jonringer deleted the fix-libmtp branch November 27, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @nh2