Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] codefresh: init at 0.74.8 #105183

Closed
wants to merge 0 commits into from
Closed

[REVIEW] codefresh: init at 0.74.8 #105183

wants to merge 0 commits into from

Conversation

jshcmpbll
Copy link
Member

@jshcmpbll jshcmpbll commented Nov 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 changed the title [REVIEW] codefresh: init at 0.73.21 codefresh: init at 0.73.21 Nov 27, 2020
SuperSandro2000
SuperSandro2000 requested changes Nov 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the global nodePackages aren't used?

@jshcmpbll
Copy link
Member Author

@SuperSandro2000 Just unfamiliarity to it. Ill look into it.

@jshcmpbll
Copy link
Member Author

build.log

Errors I am getting when I try to build. :(

@jshcmpbll
Copy link
Member Author

@SuperSandro2000 Following the steps to add a package to nodePackages there were a lot of changes to node-packages.nix. Is that expected and does that mean I have to then validate every nodepackage works after this change?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 Following the steps to add a package to nodePackages there were a lot of changes to node-packages.nix. Is that expected and does that mean I have to then validate every nodepackage works after this change?

Yeah, we need to update them all at once and no you don't need to test every package.

@SuperSandro2000
Copy link
Member

@jshcmpbll please fix the merge conflict and eval error.

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/development/node-packages/composition.nix Outdated Show resolved Hide resolved
pkgs/development/node-packages/node-env.nix Outdated Show resolved Hide resolved
pkgs/development/node-packages/node-env.nix Outdated Show resolved Hide resolved
pkgs/development/node-packages/node-env.nix Outdated Show resolved Hide resolved
pkgs/development/node-packages/node-env.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/codefresh/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/codefresh/default.nix Outdated Show resolved Hide resolved
@jshcmpbll jshcmpbll force-pushed the codefresh-0.73.21 branch 3 times, most recently from 5ad933b to 71325d9 Compare January 18, 2021 02:06
@SuperSandro2000
Copy link
Member

@jshcmpbll we have a merge conflict again. Can you give me a message on IRC when you resolved the merge conflict so that it does not happen again?

@jshcmpbll
Copy link
Member Author

@SuperSandro2000 Merge conflict is fixed.

I dont know node well enough to trouble shoot this error I'm getting. I might see if a coworker of mine can help out but if you have any thoughts id appreciate it. My assumption was that it was just missing faye-websocket but even after adding that to node-packages.json I still get that error.

npm ERR! code ENOTCACHED
npm ERR! request to https://registry.npmjs.org/faye-websocket failed: cache mode is 'only-if-cached' but no cached response available.

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/.npm/_logs/2021-01-20T09_39_31_341Z-debug.log

builder for '/nix/store/3v6g3l1kh86f2r9whk81dbhch4q9z552-node_codefresh-0.74.4.drv' failed with exit code 1
error: build of '/nix/store/3v6g3l1kh86f2r9whk81dbhch4q9z552-node_codefresh-0.74.4.drv' failed```

@ofborg ofborg bot requested a review from midchildan January 20, 2021 09:44
@SuperSandro2000
Copy link
Member

Did you try regenerating the node packages nix file?

@jshcmpbll jshcmpbll force-pushed the codefresh-0.73.21 branch 2 times, most recently from 729dff0 to 72c78bf Compare January 26, 2021 04:19
@jshcmpbll
Copy link
Member Author

Did you try regenerating the node packages nix file?

@SuperSandro2000
I did, it just looks like this package has some weird and unique dependencies I wasn't aware of. I have a workaround in place right now.. let me know if thats a valid solution - (the change to default.nix). If not im going to connect with some people over IRC and see if anyone can assist

@jshcmpbll jshcmpbll changed the title codefresh: init at 0.73.21 codefresh: init at 0.74.8 Jan 27, 2021
@jshcmpbll jshcmpbll force-pushed the codefresh-0.73.21 branch 2 times, most recently from 85a15bc to 233a3fe Compare January 27, 2021 21:58
@jshcmpbll jshcmpbll force-pushed the codefresh-0.73.21 branch 2 times, most recently from c08c997 to b200769 Compare January 28, 2021 01:22
@jshcmpbll jshcmpbll force-pushed the codefresh-0.73.21 branch 2 times, most recently from 8d44442 to 401332b Compare January 29, 2021 04:57
@jshcmpbll
Copy link
Member Author

@SuperSandro2000 Please review when you have time

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 9, 2021 •
edited

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 105183 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package failed to build and are new build failure:
49 packages built:
  • antora
  • bitwarden-cli
  • castnow
  • epgstation
  • fast-cli
  • flood
  • joplin
  • lessc
  • mastodon-bot
  • mirakurun
  • pm2
  • postcss-cli
  • pulp
  • python37Packages.batchspawner
  • python37Packages.dockerspawner
  • python37Packages.jupyterhub
  • python37Packages.jupyterhub-ldapauthenticator
  • python37Packages.jupyterhub-systemdspawner
  • python37Packages.jupyterhub-tmpauthenticator
  • python37Packages.oauthenticator
  • python38Packages.batchspawner
  • python38Packages.dockerspawner
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.oauthenticator
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.oauthenticator
  • redoc-cli
  • sloc
  • styx
  • thelounge
  • vimPlugins.coc-git
  • vimPlugins.coc-json
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-vetur
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb
  • wasm-text-gen

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python38Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python39Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

I am not sure if this is related to this update.

@jshcmpbll jshcmpbll changed the title codefresh: init at 0.74.8 [REVIEW] codefresh: init at 0.74.8 Feb 9, 2021
@jshcmpbll
Copy link
Member Author

....

@SuperSandro2000
Copy link
Member

I am talking about the netlify build failure. The other things can be safely ignored.

netlify-cli: log termbin.com/izhh

@jshcmpbll jshcmpbll closed this Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan Awaiting requested review from midchildan

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jshcmpbll @SuperSandro2000