Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogen: make man output reproducible #103985

Closed
wants to merge 1 commit into from

Conversation

picnoir
Copy link
Member

@picnoir picnoir commented Nov 16, 2020

Motivation for this change
The man page output embeds the build datetime, injecting some
indeterminism to this otherwise binary reproducible build.

Hardcoding this datetime to timestamp 0 via the MAN_PAGE_DATE env variable.

----

Before:

cat columns.1 | grep "User Commands"
.TH columns 1 "16 Nov 2020" "GNU AutoGen (1.2)" "User Commands"

After:

cat columns.1 | grep "User Commands"
.TH columns 1 "1970-01-01" "GNU AutoGen (1.2)" "User Commands"
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The man page output embeds the build datetime, injecting some
indeterminism to this otherwise binary reproducible build.

Hardcoding this datetime to timestamp 0 via the MAN_PAGE_DATE env variable.

----

Before:

cat columns.1 | grep "User Commands"
.TH columns 1 "16 Nov 2020" "GNU AutoGen (1.2)" "User Commands"

After:

cat columns.1 | grep "User Commands"
.TH columns 1 "1970-01-01" "GNU AutoGen (1.2)" "User Commands"
@picnoir
Copy link
Member Author

picnoir commented Nov 16, 2020

... I targeted master by mistake, re-opening a PR pointing to staging.

@picnoir picnoir closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant