[20.09] haskellPackages.hail: relax cabal dependencies to unbreak #103962
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream version still contains very strict dependency constraints. I've updated the patches to a version that relax these. This unbreaks hail for me. (cherry picked from commit cd11c0c)
blitz
changed the title
ofborg
bot
added
6.topic: haskell
10.rebuild-darwin: 0
cdepillabout
requested changes
Nov 16, 2020
There was a problem hiding this comment.
Ah, sorry for the lack of documentation around this, but on the release branches you'll actually need to update the hail entry in pkgs/development/haskell-modules/hackage-packages.nix, since that file doesn't get updated automatically.
- Please remove the
broken = true;andhydraPlatforms =line for thehailderivation inpkgs/development/haskell-modules/hackage-packages.nix - Leave the change in
pkgs/development/haskell-modules/configuration-hackage2nix.yaml, in case someone would want to regenerate the package set.
This has to be done manually on release branches.
ofborg
bot
added
8.has: package (new)
|
@cdepillabout Thanks for the explanation! I've updated the PR. |
|
Looks like this builds, thanks for fixing it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a backport of #103579. Original description follows:
The upstream version still contains very strict dependency
constraints. I've updated the patches to a version that relax these.
This unbreaks hail for me.
See james-preston/hail#16 for the upstream fix.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)@tfc @peti @cdepillabout