Make autogen.man reproducible #103974
Merged
Make autogen.man reproducible #103974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this is something that should be merged in staging, judging by how many packages need to be rebuilt. |
|
Doesn't seem necessary to put this in 2 different commits. and yes it needs to target staging. |
Keep the date format similar to what it is when we are not using the MAN_PAGE_DATE env var. The man pages scripts seem to use different formats in different pages, so we use the most common format for all.
basile-henry
force-pushed
the
basile-henry/reproducible-autogen-man
branch
from
3a466c6
to
edd3e40
Compare
basile-henry
requested review from
alyssais,
Ericson2314,
FRidh,
jonringer,
matthewbauer,
stigtsp and
ttuegel
as code owners
ofborg
bot
added
6.topic: nixos
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: stdenv
10 tasks
|
It seems like we were working on that concurently :) #103986 Note we have a IRC channel to sync the r13y effort, #nixos-r13y on freenode. [Edit] first 😅 |
This comment has been minimized.
This comment has been minimized.
|
Ah, sorry about the duplicated efforts @NinjaTrappeur! 😅 I'll join the IRC channel to coordinate for future r13y work 👍 |
|
Is there anything I need to do to get this PR over the line? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Working towards a reproducible iso_minimal (https://r13y.com/)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)