Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary jquery-ui reference #223

Merged
merged 3 commits into from Nov 17, 2020
Merged

Remove unnecessary jquery-ui reference #223

merged 3 commits into from Nov 17, 2020

Conversation

BenediktSeidl
Copy link
Contributor

This file seems to be missing since 2020-09-22:
https://web.archive.org/web/20200922051906/https://nixos.org/js/jquery-ui.min.js

As there are no bug reports since then, I think it may be save to remove the reference?

@turboMaCk
Copy link
Member

turboMaCk commented Nov 16, 2020 •
edited

I'm not sure if we even want to have jquery there. Even dynamic bootstrap stuff won't work with elm's vdom I believe.

@BenediktSeidl BenediktSeidl force-pushed the remove-jquery-ui branch 2 times, most recently from 3cec212 to b63b206 Compare November 16, 2020 20:45
@BenediktSeidl
remove jquery script and bootstrap javascript
d400ed4 
it seems not to be used by this project, jquery is a dependency of
bootstrap
@BenediktSeidl
remove font-awesome css
c8eff09
@BenediktSeidl
Copy link
Contributor Author

I'm not sure if we even want to have jquery there. Even dynamic bootstrap stuff won't work witl elm's vdom I believe.

grepping over the project it seems like jquery is not in use so i removed it. the bootstrap script throws an error, so i was bold enough to remove this, too. everything seems to work fine.

it seems like font-awesome is also not in use, as i could not see any fonts loaded in the developer tools, so i removed this, too.

@turboMaCk
Copy link
Member

yes the twitter bootstrap (ui framework) comes with some JS which depends on jquery. Anyway I think this JS won't work with elm anyway so I think removing it is a good approach. Anyway this will need to be tested.

@garbas
Copy link
Member

garbas commented Nov 17, 2020

I'm fixing the github actions in #227 and then i'll merge this.

@garbas garbas merged commit 4d505f3 into NixOS:master Nov 17, 2020
@BenediktSeidl BenediktSeidl deleted the remove-jquery-ui branch November 17, 2020 19:14
turboMaCk added a commit that referenced this pull request Jan 20, 2021
@turboMaCk
Revert "Remove unnecessary jquery, jquery-ui and bootstrap javascript…
3939a02 
… reference and font-awesome css (#223)"

This reverts commit 4d505f3.
turboMaCk added a commit that referenced this pull request Jan 20, 2021
@turboMaCk
Fix mobile only interactions (#267)
1c1a3ca 
* Revert "Remove unnecessary jquery, jquery-ui and bootstrap javascript reference and font-awesome css (#223)"

This reverts commit 4d505f3.

* Remove unused dependecies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenediktSeidl @turboMaCk @garbas