[20.09] elixir_1_6: remove #103971
[20.09] elixir_1_6: remove #103971
Conversation
Additionally removed the now obsolete rebar build dependency for elixir.
veprbl
changed the title
|
Why not remove dependency on |
|
@veprbl because 1.6 depends on rebar to work sadly. |
|
@DianaOlympos Can we then remove it for all versions except for 1.6? |
|
@veprbl probably but that is going to be painful. Also it mean that elixir 1.6 will not work on otp 23 and fail to compile, while we do ship otp 23 in 20.09. So that would still be a problem |
|
@DianaOlympos you could mark it as broken for that particular combination. If you are sure that impact of removing 1.6 is minimal, we can merge this as is of course. |
|
It should be fine to remove it. Elixir 1.11 is the most recent version and there have been no commits to the 1.6 branch for over two years. Ecto currently also expects 1.8+, which I sometimes use as a litmus test for versions because a couple core Elixir folks work on it. |
Additionally removed the now obsolete rebar build dependency for elixir.
Motivation for this change
As noted by @cw789 in his original PR #98649, rebar does not compile anymore on otp 23.
We allowed otp 23 in nixos 20.09, which means that all compilation of elixir are broken sometimes, because they depend on rebar, which does not compile on otp 23. On top of that, rebar has problems with openssl in general.
I know this drop elixir 1.6, which technically could break people using it. Elixir should be fully backward compatible, so they should be able to update to a newer one. On top of this, 1.6 was the last one depending on rebar and cannot be compiled on otp23 in the current state anyway.
So or we break anyone using otp 23 with elixir, or we break people using elixir 1.6.
I understand if the decision is to keep the current (broken) situation. @ankhers what do you think ?
Things done
Remove elixir 1.6. remove elixir dependency on rebar