Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmicrohttpd dependents: fix build #105242

Merged
merged 4 commits into from Dec 4, 2020
Merged

libmicrohttpd dependents: fix build #105242

merged 4 commits into from Dec 4, 2020

Conversation

RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 28, 2020 •
edited

Motivation for this change

microhttpd 0.9.71 introduced a breaking change that broke xmr-stak (and possibly other packages, I will be checking others)

This PR updates the libmicrohttpd derivation to allow for having multiple versions of it in nixpkgs, and updates xmr-stak, fileshare, and faustlive to use 0.9.70, prior to the breaking change.

cpp-ethereum (now known as aleth) is also broken due to this - however, it requires libjon-rpc-cpp to be fixed as well.

Additionally, aleth is now abandon ware (https://gitter.im/ethereum/aleth?at=5e7cb22c2520175199ead0ba), it may be worthwhile to consider removing it since nothing seems to depend on it, and actually running it will not get you very far.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood
Copy link
Member Author

Result of nixpkgs-review pr 105242 1

2 packages built:
  • libmicrohttpd_0_9_70
  • xmr-stak

@RaghavSood RaghavSood mentioned this pull request Nov 28, 2020
Closed
10 tasks
SuperSandro2000
SuperSandro2000 reviewed Nov 28, 2020
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -14289,7 +14289,9 @@ in

libmemcached = callPackage ../development/libraries/libmemcached { };

libmicrohttpd = callPackage ../development/libraries/libmicrohttpd { };
libmicrohttpd_0_9_70 = callPackage ../development/libraries/libmicrohttpd/0.9.70.nix { };
libmicrohttpd_0_9_71 = callPackage ../development/libraries/libmicrohttpd/0.9.71.nix { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
libmicrohttpd_0_9_71 = callPackage ../development/libraries/libmicrohttpd/0.9.71.nix { };
libmicrohttpd_0_9_71 = callPackage ../development/libraries/libmicrohttpd/default.nix { };

And maybe we shouldn't use the generic file if they diverge in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally a little unclear on when to use default.nix vs generic.nix in such scenarios - most libraries where the inputs and build process remains the same seem to use generic, but there are a bunch which use default as well (usually, those have varying build inputs too)

I could live with changing it back to default if people agree that's a better fit here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microhttpd doesn't see a whole lot of development - personally, I'd leave the generic derivation for now - the dependencies haven't really changed in a while.

If they do diverge, we could split it up, but I don't see a point in preemptively adding in extra things we may not need by splitting it up now

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105242 run on x86_64-linux 1

3 packages built:
  • libmicrohttpd_0_9_70
  • libmicrohttpd_0_9_71
  • xmr-stak

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105242 run on x86_64-darwin 1

2 packages built:
  • libmicrohttpd_0_9_70
  • libmicrohttpd_0_9_71

@RaghavSood RaghavSood changed the title xmr-stak: fix build libmicrohttpd dependents: fix build Nov 29, 2020
@ofborg ofborg bot requested a review from esclear November 29, 2020 09:59
@RaghavSood
Copy link
Member Author

Result of nixpkgs-review pr 105242 1

4 packages built:
  • faustlive
  • fileshare
  • libmicrohttpd_0_9_70
  • xmr-stak

@RaghavSood RaghavSood merged commit 3a3e8e6 into NixOS:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@edolstra edolstra Awaiting requested review from edolstra

@fpletz fpletz Awaiting requested review from fpletz

@bfortz bfortz Awaiting requested review from bfortz

@vrthra vrthra Awaiting requested review from vrthra

@esclear esclear Awaiting requested review from esclear

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RaghavSood @SuperSandro2000