Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio-experimental, factorio-headless-experimental: 1.1.1 -> 1.1.2 #105232

Closed
wants to merge 1 commit into from
Closed

factorio-experimental, factorio-headless-experimental: 1.1.1 -> 1.1.2 #105232

wants to merge 1 commit into from

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 28, 2020

Motivation for this change

Update factorio experimental to latest version 1.1.2.

Changelog: https://forums.factorio.com/viewtopic.php?f=3&t=92158

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from elitak, erictapen and Baughn November 28, 2020 14:49
@mweinelt
Copy link
Member

Sorry, you were bit late. But maybe you can review #105231?

@lukegb lukegb closed this Nov 28, 2020
@lukegb lukegb deleted the factorio-1.1.2 branch December 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elitak elitak Awaiting requested review from elitak

@erictapen erictapen Awaiting requested review from erictapen

@Baughn Baughn Awaiting requested review from Baughn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @mweinelt