-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interrupt the orbit analysis if the mission duration changes #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
approved these changes
Nov 28, 2020
base/jthread.hpp
Outdated
@@ -123,6 +124,13 @@ class this_stoppable_thread { | |||
friend jthread MakeStoppableThread(Function&& f, Args&&... args); | |||
}; | |||
|
|||
#define RETURN_IF_STOPPED \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if this should take (optionally) a parameter to let the caller propagate a useful message.
I am also wondering if our macro names should systematically start with PRINCIPIA_
.
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to do that:
operator=
of our implementation ofjthread
;RETURN_IF_STOPPED
;OrbitalElements
and related functions;RETURN_IF_STOPPED
;Status
for move semantics (what year is this).The analyser can lag a little bit when updating the mission duration during the actual analysis (as opposed to the integration), I think the remaining large atomic operations are vector destructions; not much we can easily do about those.
Drive-by changes: take an exclusive lock to swap, not a reader lock, don’t flow twice to the same time.