Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli2: 2.0.54 -> 2.1.3 #104453

Merged
merged 1 commit into from Nov 22, 2020
Merged

awscli2: 2.0.54 -> 2.1.3 #104453

merged 1 commit into from Nov 22, 2020

Conversation

davegallant
Copy link
Member

@davegallant davegallant commented Nov 21, 2020 •
edited

Motivation for this change

Fix for compatibility issue with python3Packages.colorama: #104421 (blocking: #103718)

Related PR: #102134

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

markus1189
markus1189 approved these changes Nov 21, 2020
View reviewed changes
Copy link
Contributor

@markus1189 markus1189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine for me.

Tested with nix run nixpkgs.nixpkgs-review -c nixpkgs-review pr 104453

flokli
flokli approved these changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eval error seems unrelated.

@flokli flokli merged commit b203be9 into NixOS:master Nov 22, 2020
@flokli flokli mentioned this pull request Nov 22, 2020
Closed
@afreakk afreakk mentioned this pull request Nov 22, 2020
Closed
10 tasks
@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 23, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@markus1189 markus1189 markus1189 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davegallant @flokli @markus1189