Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11.vulkan_beta: 450.56.11 -> 455.46.01 #104455

Merged
merged 1 commit into from Dec 13, 2020
Merged

nvidia_x11.vulkan_beta: 450.56.11 -> 455.46.01 #104455

merged 1 commit into from Dec 13, 2020

Conversation

expipiplus1
Copy link
Contributor

@expipiplus1 expipiplus1 commented Nov 21, 2020 •
edited

Still need to test, hence WIP Seems to work well

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@expipiplus1 expipiplus1 marked this pull request as draft November 21, 2020 05:32
@expipiplus1 expipiplus1 marked this pull request as ready for review November 21, 2020 05:43
@SuperSandro2000
Copy link
Member

Can you rebase this branch on master to fix the eval error?

@expipiplus1
Copy link
Contributor Author

Done, I also bumped it to 455.46.02, released yesterday.

@expipiplus1
Copy link
Contributor Author

Is it possible to get this merged please?

@expipiplus1
Copy link
Contributor Author

ping..

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104455 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.nvidia_x11_vulkan_beta
  • linuxPackages_hardkernel_latest.nvidia_x11_vulkan_beta
17 packages built:
  • linuxPackages-libre.nvidia_x11_vulkan_beta
  • linuxPackages.nvidia_x11_vulkan_beta (linuxPackages_5_4.nvidia_x11_vulkan_beta)
  • linuxPackages_4_14.nvidia_x11_vulkan_beta
  • linuxPackages_4_19.nvidia_x11_vulkan_beta
  • linuxPackages_4_4.nvidia_x11_vulkan_beta
  • linuxPackages_4_9.nvidia_x11_vulkan_beta
  • linuxPackages_5_8.nvidia_x11_vulkan_beta
  • linuxPackages_5_9.nvidia_x11_vulkan_beta (linuxPackages_latest.nvidia_x11_vulkan_beta)
  • linuxPackages_hardened.nvidia_x11_vulkan_beta
  • linuxPackages_latest-libre.nvidia_x11_vulkan_beta
  • linuxPackages_latest_hardened.nvidia_x11_vulkan_beta
  • linuxPackages_latest_xen_dom0.nvidia_x11_vulkan_beta
  • linuxPackages_latest_xen_dom0_hardened.nvidia_x11_vulkan_beta
  • linuxPackages_testing_bcachefs.nvidia_x11_vulkan_beta
  • linuxPackages_xen_dom0.nvidia_x11_vulkan_beta
  • linuxPackages_xen_dom0_hardened.nvidia_x11_vulkan_beta
  • linuxPackages_zen.nvidia_x11_vulkan_beta

@expipiplus1
Copy link
Contributor Author

Is it possible to merge this please?

@SuperSandro2000 SuperSandro2000 merged commit 0f08fc1 into NixOS:master Dec 13, 2020
@expipiplus1
Copy link
Contributor Author

Thanks

@expipiplus1 expipiplus1 deleted the joe-nvidia branch December 13, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @SuperSandro2000