Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blktrace: adding patch for CVE-2018-10689 from upstream. #104454

Closed

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 21, 2020

Motivation for this change

Addresses #90747 - CVE-2018-10689

Applied patch from: https://git.kernel.dk/?p=blktrace.git;a=patch;h=d61ff409cb4dda31386373d706ea0cfb1aaac5b7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Can you rebase this branch on master to fix the eval error?

@redvers
Copy link
Member Author

redvers commented Nov 23, 2020

Result of nixpkgs-review pr 104454 1

1 package built:
  • blktrace

@redvers
Copy link
Member Author

redvers commented Nov 23, 2020

Looking at doing the rebase now, thanks.

@redvers redvers force-pushed the patch_CVE-2018-10689_with_patch_master branch from 5675158 to 713c0ad Compare November 23, 2020 14:45
@redvers
Copy link
Member Author

redvers commented Nov 23, 2020

Result of nixpkgs-review pr 104454 1

1 package built:
  • blktrace

@mweinelt
Copy link
Member

mweinelt commented Dec 1, 2020

Please use fetchpatch to acquire the patch, we don't need to track it in nixpkgs. Also the commit message needs the usual improvements.

@applePrincess
Copy link
Contributor

I will close this as this patch only needs blktrace version 1.2.0, stated in NVD and current master branch has 1.3.0 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants