Refresh instance metadata on boot #104456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Nov 22, 2020
The metadata fetcher scripts run each time an instance starts, and it is not safe to assume that responses from the instance metadata service (IMDS) will be as they were on first boot. Example: an EC2 instance can have its user data changed while the instance is stopped. When the instance is restarted, we want to see the new user data applied.
endgame
force-pushed
the
refresh-instance-metadata-on-boot
branch
from
11b70c5
to
4187098
Compare
Nixops will not change the ssh hostkeys even on userdata change, because the hostkey will still exists: I think it will still run the same amazon-init service and reapply configuration.nix userdata: Should any of this discussion be replicated in the release notes? Also, do you have any idea what might be going wrong with the docbook stuff? |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
grahamc
reviewed
Nov 22, 2020
endgame
force-pushed
the
refresh-instance-metadata-on-boot
branch
2 times, most recently
from
6ef3a5c
to
1b653b2
Compare
endgame
force-pushed
the
refresh-instance-metadata-on-boot
branch
from
1b653b2
to
6fd871d
Compare
grahamc
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Re-fetch instance meta data/user data on each boot. This means that we can stop instances, change user data, reboot the instance, and expect the new user data to actually be applied.
NOTE I tried to cargo-cult the docbook but I must have screwed it up. Help please?Never mind, my test instance ran out of memory trying to rebuild docs.Things done
Ping @grahamc