Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlsec: 1.2.30 -> 1.2.31 #104472

Merged
merged 2 commits into from Nov 21, 2020
Merged

xmlsec: 1.2.30 -> 1.2.31 #104472

merged 2 commits into from Nov 21, 2020

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Otherwise the build fails the tests. Probably a regression since the
update of nss to 3.59.
@doronbehar
Copy link
Contributor Author

kmymoney works with this patch.

Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 104472 1

8 packages built:
  • aqbanking
  • gnucash
  • kmymoney
  • lasso
  • matrix-synapse
  • python37Packages.pysaml2
  • python38Packages.pysaml2
  • xmlsec

Thanks, fixes matrix-synapse with SAML2 login for me.

@doronbehar doronbehar merged commit 840661a into NixOS:master Nov 21, 2020
@doronbehar doronbehar deleted the pkg/xmlsec branch November 21, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants