Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python27Packages: no longer build and prefer #104469

Closed
wants to merge 1 commit into from
Closed

python27Packages: no longer build and prefer #104469

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 21, 2020 •
edited

The Python 2 packages set will remain available, however, it will not be
built by Hydra or ofBorg.

While some have expressed their desire to have a Python2 set around,
there has hardly been any effort to keep it working.

Not building Python 2 allows us to build an additional Python 3 set
(currently Python 3.9), which is important since Python switched
to a yearly release cadence.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from jonringer November 21, 2020 08:29
@FRidh
python27Packages: no longer build and prefer
b52e915 
The Python 2 packages set will remain available, however, it will not be
built by Hydra or ofBorg.

While some have expressed their desire to have a Python2 set around,
there has hardly been any effort to keep it working.

Not building Python 2 allows us to build an additional Python 3 set
(currently Python 3.9), which is important since Python switched
to a yearly release cadence.
@FRidh
Copy link
Member Author

FRidh commented Nov 21, 2020

Note other packages can still depend on the Python 2 set. In that case, the necessary packages will still be built.

@ofborg ofborg bot removed the 6.topic: python label Nov 21, 2020
@FRidh
Copy link
Member Author

FRidh commented Nov 21, 2020

@GrahamcOfBorg eval

@FRidh
Copy link
Member Author

FRidh commented Nov 21, 2020

Pushed to staging 9ce7b79.

@FRidh FRidh closed this Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh