Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt515.qtwebkit: unbreak #104474

Merged
merged 9 commits into from Dec 11, 2020
Merged

qt515.qtwebkit: unbreak #104474

merged 9 commits into from Dec 11, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 21, 2020 •
edited by dotlambda

Motivation for this change

More qt515 fixes (like #102840) with unbroken qt515.qtwebkit.

Here's a git grep list of packages that use qt514 in all-packages.nix. Ideally each of them needs to have at least a comment explaining why it uses qt514 and not qt515. Usually they are pinned to qt514 since qt515.qtwebkit is broken on master, but not on this branch - hence every package listed here likely can use qt515.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Nov 21, 2020
Merged
10 tasks
@doronbehar doronbehar changed the title qt515.qtwebkit: unbreak 🎉 qt515.qtwebkit: unbreak Nov 21, 2020
@doronbehar
Copy link
Contributor Author

cc @freezeboy for review.

@ofborg ofborg bot requested review from FRidh, periklis and abbradar November 21, 2020 09:54
This was referenced Nov 21, 2020
Merged
Merged
Merged
@freezeboy
Copy link
Contributor

freezeboy commented Nov 21, 2020 •
edited

Looks good to me

@ofborg ofborg bot requested a review from layus November 21, 2020 10:10
@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

konversation: 1.7.5 -> 1.7.5

Should be 1.7.7.

@doronbehar
Copy link
Contributor Author

Should be 1.7.7.

Fixed.

@doronbehar doronbehar mentioned this pull request Nov 22, 2020
Closed
10 tasks
@ttuegel
Copy link
Member

ttuegel commented Dec 11, 2020

I updated the top comment to ping the relevant maintainers.

Please test your packages with Qt 5.15, and un-pin them from Qt 5.14 if everything is working. (Note: this will probably not be possible for proprietary applications.)

@turion
Copy link
Contributor

turion commented Dec 11, 2020

Does that mean we should use libsForQt5 or libsForQt515? Probably libsForQt5 is better?

turion added a commit to turion/nixpkgs that referenced this pull request Dec 11, 2020
@turion
krusader: Unpin qt514 -> qt515
de3d3df 
As requested in NixOS#104474
@turion turion mentioned this pull request Dec 11, 2020
Merged
10 tasks
@freezeboy
Copy link
Contributor

Yes better to use the generic version to avoid the same problem with many programs pinned to 5.15 when the default qt5 will be updated

@tfmoraes tfmoraes mentioned this pull request Dec 11, 2020
Merged
10 tasks
@SCOTT-HAMILTON SCOTT-HAMILTON mentioned this pull request Dec 11, 2020
Merged
10 tasks
@risicle risicle mentioned this pull request Dec 11, 2020
Merged
10 tasks
@rycee rycee mentioned this pull request Dec 11, 2020
Closed
10 tasks
This was referenced Dec 12, 2020
Merged
Merged
@erictapen erictapen mentioned this pull request Dec 12, 2020
Merged
10 tasks
@gebner gebner mentioned this pull request Dec 12, 2020
Merged
10 tasks
@TimPut TimPut mentioned this pull request Dec 12, 2020
Merged
10 tasks
@erictapen erictapen mentioned this pull request Dec 12, 2020
Merged
10 tasks
@tfmoraes tfmoraes mentioned this pull request Dec 15, 2020
Merged
10 tasks
@FRidh FRidh mentioned this pull request Dec 22, 2020
Merged
10 tasks
@doronbehar doronbehar mentioned this pull request Dec 23, 2020
Merged
16 tasks
ttuegel added a commit to ttuegel/nixpkgs that referenced this pull request Dec 25, 2020
@ttuegel
Merge pull request NixOS#104474 from doronbehar/pkg/qt515/qtwebkit
a487bae 
qt515.qtwebkit: unbreak

(cherry picked from commit e772531)
@ttuegel ttuegel mentioned this pull request Dec 26, 2020
Merged
10 tasks
@fgaz
Copy link
Member

fgaz commented Jan 1, 2021 •
edited

evilpixie waiting on upstream: bcampbell/evilpixie#14 done in #108215

@fgaz fgaz mentioned this pull request Jan 2, 2021
Merged
10 tasks
This was referenced Jan 5, 2021
Closed
Merged
Closed
This was referenced Feb 3, 2021
Merged
Merged
@dotlambda
Copy link
Member

There seems to be a limit to the number of people you can ping in a message. We should remove the maintainer ping for the packages that have already been fixed.

@doronbehar doronbehar deleted the pkg/qt515/qtwebkit branch March 2, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

@layus layus Awaiting requested review from layus

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qtwebkit marked as broken
9 participants
@doronbehar @freezeboy @FRidh @ctheune @ttuegel @turion @fgaz @dotlambda @SuperSandro2000