New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coreutils, findutils, gnutls: fix build on 32-bit ARM #103925
Conversation
Adds an upstream patch to fix failing tests. The patch actually affects gnulib, which is included as a vendored dependency.
Add an upstream patch to fix failing tests. The patch actually affects gnulib, which is included as a vendored dependency.
6c0f29c
to
0f5235b
Compare
findutils also needs the same patch. I made a copy of the patch, so that we don't have to worry about someone deleting it while another package is still using it. I'm not sure if there are other packages that use gnulib and need this patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built ok on armv7l-linux. This is a backport of an upstream change that's preventing building almost anything on armv7l-linux. LGTM.
Add an upstream patch to fix failing tests. The patch actually affects gnulib, which is included as a vendored dependency.
I found that gnutls needs the same fix. |
I started an evaluation on my hydra: https://hydra.cons.org.nz/eval/3297?compare=nixpkgs-unstable |
only mtdutils seems to be failing |
That looks like an unrelated issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for this!
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
Adds an upstream patch to fix tests that fail on 32-bit ARM. The patch actually affects gnulib, which is included as a vendored dependency.
I only applied the patch to 32-bit ARM so this could go in master, but we need to remember to remove it when updating.
cc @edolstra @NeQuissimus @dtzWill
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)