Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transgui: patch to circumvent v3 rpc issue #103909

Merged
merged 1 commit into from May 6, 2022
Merged

transgui: patch to circumvent v3 rpc issue #103909

merged 1 commit into from May 6, 2022

Conversation

RamKromberg
Copy link
Contributor

Motivation for this change

#97430

Things done

reviewed the source and read up on the rpc; added the patch; built and executed on nixos 20.09; tried out adding, removing and moving torrents to verify nothing gets accidentally deleted...

I'm still not too happy about what essentially comes down to circumventing rpc changes between versions instead of properly updating the sources to the new specs but I haven't noticed anything that can lead to data loss and upstream hasn't reviewed much other than translations for months AND this project has a long history of going out of maintenance and forking...

@RamKromberg
Copy link
Contributor Author

switched from 1329 to 1354 due to transmission-remote-gui/transgui#1354 (comment)

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 2, 2022
@RamKromberg
Copy link
Contributor Author

sorry. I had a cold. 🦜

Anyhow, should be up-to-date and patched up for the not-so-new v.3 daemon rpc protocol.

@RamKromberg
Copy link
Contributor Author

made the changes requested, updated and rebased on current master.

@RamKromberg
Copy link
Contributor Author

btw, I'm not sure what to make of the farm's build failure as it builds fine on my system.

@SuperSandro2000
Copy link
Member

It can't link on aarch64-linux.

make[4]: Entering directory '/build/fpcbuild-3.2.0/fpcsrc/packages/fpmkunit'
/nix/store/n35z01fwkf0alzn5igg5l4phc9r8gdk6-coreutils-9.0/bin/mkdir -p units_bs/aarch64-linux
/build/fpcbuild-3.2.0/fpcsrc/compiler/ppca64 src/fpmkunit.pp  -Fu/build/fpcbuild-3.2.0/fpcsrc/rtl/units/aarch64-linux -FUunits_bs/aarch64-linux -Fu../paszlib/src -Fu../hash/src -Fi../paszlib/src  -Fi../fcl-process/src/unix -Fu../fcl-process/src -Fi../fcl-process/src/linux -Fi../fcl-process/src/dummy -Fu../libtar/src 
make[4]: Leaving directory '/build/fpcbuild-3.2.0/fpcsrc/packages/fpmkunit'
/build/fpcbuild-3.2.0/fpcsrc/compiler/ppca64 fpmake.pp  -Fu/build/fpcbuild-3.2.0/fpcsrc/packages/fpmkunit/units_bs/aarch64-linux -Fu/build/fpcbuild-3.2.0/fpcsrc/rtl/units/aarch64-linux  
/nix/store/vwsfkvn1zp4z0gznxx2r478v0rrwncpk-binutils-2.38/bin/ld: /build/fpcbuild-3.2.0/fpcsrc/rtl/units/aarch64-linux/cprt0.o: in function `_start':
(.text+0x54): undefined reference to `__libc_csu_init'
/nix/store/vwsfkvn1zp4z0gznxx2r478v0rrwncpk-binutils-2.38/bin/ld: (.text+0x58): undefined reference to `__libc_csu_init'
/nix/store/vwsfkvn1zp4z0gznxx2r478v0rrwncpk-binutils-2.38/bin/ld: (.text+0x5c): undefined reference to `__libc_csu_fini'
/nix/store/vwsfkvn1zp4z0gznxx2r478v0rrwncpk-binutils-2.38/bin/ld: (.text+0x60): undefined reference to `__libc_csu_fini'
fpmake.pp(55) Error: Error while linking
fpmake.pp(55) Fatal: There were 1 errors compiling module, stopping
Fatal: Compilation aborted
make[3]: *** [Makefile:1725: fpmake] Error 1
make[3]: Leaving directory '/build/fpcbuild-3.2.0/fpcsrc/packages'
make[2]: *** [Makefile:2681: packages_smart] Error 2
make[2]: Leaving directory '/build/fpcbuild-3.2.0/fpcsrc'
make[1]: *** [Makefile:2836: build-stamp.aarch64-linux] Error 2
make[1]: Leaving directory '/build/fpcbuild-3.2.0/fpcsrc'
make: *** [Makefile:2307: fpcsrc/build-stamp.aarch64-linux] Error 2

@RamKromberg
Copy link
Contributor Author

I forgot the magic one liners to spin qemu minimal systems and I never did it aiming on another arch so this will have to wait until someone who owns an ARM would give it a go. Best I can do is abuse the build server with platforms = [ "x86_64-linux" "x86_64-darwin" ]; and see at least that sticks. I believe ARM has an emulation thing going so maybe they'll be able to use it like or something... IDK.

SuperSandro2000
SuperSandro2000 requested changes May 4, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@RamKromberg
Copy link
Contributor Author

made the final requested change to the patch url and corrected "Bit-Torrent" into "BitTorrent" in the meta.description while at it.

@SuperSandro2000 SuperSandro2000 merged commit 7278295 into NixOS:master May 6, 2022
@RamKromberg
Copy link
Contributor Author

Thanks and sorry it took so long :)

@RamKromberg RamKromberg deleted the fix/transgui branch May 6, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RamKromberg @SuperSandro2000