Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: Link native-lisp directory into Mac app #103933

Merged
merged 2 commits into from Dec 3, 2020
Merged

emacs: Link native-lisp directory into Mac app #103933

merged 2 commits into from Dec 3, 2020

Conversation

nuance
Copy link
Contributor

@nuance nuance commented Nov 15, 2020

Without the symlink, the application can't be launched.

Fixes nix-community/emacs-overlay#71

Motivation for this change

I'm not able to launch the emacs application on macOS with native comp enabled. This has been reported on the emacs-overlay repo, along with a link to a fix: nix-community/emacs-overlay#71 (comment)

I've tested this locally via my home-manager config and am creating this to fix it in the original nixpkgs.

I'm unsure how to correctly handle the version in the path (28.0.50) for this fix and welcome any advice or suggestions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nuance
emacs: Link native-lisp directory into Mac app
ab220e7 
Without the symlink, the application can't be launched.

Fixes <nix-community/emacs-overlay#71>
veprbl
veprbl reviewed Nov 18, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to also report this upstream

@veprbl veprbl added the 6.topic: darwin Running or building packages on Darwin label Nov 22, 2020
antifuchs
antifuchs approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@antifuchs antifuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reported this to the emacs BTS a while ago, but we couldn't come up with a good solution in code: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43137

This seems like a much easier way to fix the problem. Let's do this, I think.

@veprbl veprbl merged commit 571b17d into NixOS:master Dec 3, 2020
@adisbladis adisbladis mentioned this pull request Feb 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@antifuchs antifuchs antifuchs approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dlopen issue on macOS
4 participants
@nuance @antifuchs @veprbl @Janik-Haag