Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multimc: remove root directory flag #103927

Closed
wants to merge 1 commit into from
Closed

multimc: remove root directory flag #103927

wants to merge 1 commit into from

Conversation

soulsoiledit
Copy link

@soulsoiledit soulsoiledit commented Nov 15, 2020

Motivation for this change

MultiMC already uses $XDG_DATA_HOME/multimc and $HOME/.multimc as root directory paths. This flag is redundant and caused confusion when it did not look for and create those directories in the correct order.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

MultiMC already uses $XDG_DATA_HOME/multimc and $HOME/.multimc as default root directories
@soulsoiledit
Copy link
Author

soulsoiledit commented Dec 13, 2020

Merged in #96192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants