Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gping: 1.1 -> 0.1.6 #103918

Closed
wants to merge 2 commits into from
Closed

gping: 1.1 -> 0.1.6 #103918

wants to merge 2 commits into from

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

The software received an update which is a complete rewrite in rust, they went back
to 0.x branch but it is still new

If you want to test this PR, you must use the module in order to add the security wrapper

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
gping: 1.1 -> 0.1.6
0f4a795 
Beware, the software has been rewritten in rust and they went back to
0.x branch, this is still a newer version
@ofborg ofborg bot requested a review from andrew-d November 15, 2020 17:43
@Mindavi
Copy link
Contributor

Mindavi commented Nov 15, 2020

I have build this (nix-shell -p nixpkgs-review --run "nixpkgs-review pr 103918") and the result works for me. I'm using NixOS as well.

I did not use the module for the security wrapper, is that required for proper testing? Unsure how to apply / use it.

@freezeboy
Copy link
Contributor Author

Well when running the gping command it doesn't seem to launch pings over the network on my side so I thought it was the setuid problem ...

maybe I had another problem

@danieldk
Copy link
Contributor

This is a (partial) duplicate of #103767. I tested the other PR and it worked fine without a wrapper.

@danieldk danieldk closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-d andrew-d Awaiting requested review from andrew-d

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @Mindavi @danieldk