Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kak-prelude: Fix installation path #103937

Merged
merged 1 commit into from Nov 23, 2020
Merged

kak-prelude: Fix installation path #103937

merged 1 commit into from Nov 23, 2020

Conversation

buffet
Copy link
Member

@buffet buffet commented Nov 15, 2020

Motivation for this change

Apparently I forgot to change the installation path while copy pasting.

Should I also update some sort of revision?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

buffet referenced this pull request Nov 15, 2020
@alyssais
kak-prelude: init at 2020-03-15
5aeff94
@rycee
Copy link
Member

rycee commented Nov 15, 2020

I'm no Kakoune expert but as long as the plugin still can be found by Kakoune I think this should be fine. No need to change any revision.

@SuperSandro2000 SuperSandro2000 merged commit 0f96ab0 into NixOS:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buffet @rycee @SuperSandro2000