Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl_433: 20.02 -> 20.11 #103936

Merged
merged 1 commit into from Nov 24, 2020
Merged

rtl_433: 20.02 -> 20.11 #103936

merged 1 commit into from Nov 24, 2020

Conversation

Mindavi
Copy link
Contributor

@Mindavi Mindavi commented Nov 15, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @earldouglas

@Mindavi
rtl_433: 20.02 -> 20.11
956ba19 
Also change to using cmake for the build (this is best supported by
upstream) and enable the automated tests for rtl_433.

The description could also use some love, so improved that as well.
@ofborg ofborg bot requested a review from earldouglas November 15, 2020 22:08
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103936 run on x86_64-linux 1

1 package built:
  • rtl_433

@SuperSandro2000 SuperSandro2000 merged commit 8fe8595 into NixOS:master Nov 24, 2020
@Mindavi Mindavi deleted the rtl-433/20.11 branch November 24, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earldouglas earldouglas earldouglas approved these changes

@danielfullmer danielfullmer danielfullmer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mindavi @SuperSandro2000 @earldouglas @danielfullmer