New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cura: 4.7.1 -> 4.8.0 #103941
cura: 4.7.1 -> 4.8.0 #103941
Conversation
@gebner Turns out updating Cura to 4.8.0 wasn't as easy as I thought it'd be. What are your thoughts on switching to an AppImage wrapper? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd strongly prefer continuing to build from source.
Looking at the previous update PR, it looks like you need to upgrade liburanium, libsavitar, libarcus and curaengine as well.
stdenv.mkDerivation rec { | ||
version = "4.8.0"; | ||
pname = "libnest2d"; | ||
format = "other"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't belong here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm not sure what you mean. Should this file be in another folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format = "other"
is only for buildPythonPackage
as far as I know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format = "other"; |
Please just remove the format = "other"
line.
Haha I thought that might be the case
Once I got the pynest2d bit sorted, I was going to move on to those, but thanks for pointing them out (now I have a clear list to work off haha) Thanks for your help @lopsided98 ! I'll continue on this after work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get now:
hash mismatch in fixed-output derivation '/nix/store/6xjdlcbfv2wckgmv8jy0vnwrpfiwwx3l-source':
wanted: sha256:0hi9w1fsnazlr0vvxdr3alsdb8m1vjjfp5zhmlz4kyyxhsy3bc33
got: sha256:1wyzx4fxbyd0mvf3x4p7crcnp38hgfr4zd3cc40nk9c0c51awplv
cannot build derivation '/nix/store/hn1f0rnw3fgvd583nkqawpwprpzsk6z3-cura-4.8.0.drv': 1 dependencies couldn't be built
Beyond the 2 issues mentioned above, this upgrade works for me and slices my test file fine. |
That's odd, I wonder why I didn't get the same error. I've updated the SHA. Thanks for testing! |
Perhaps you did the update, putting in that SHA and it was right at the time, and then changed the URL/version again but forgot to update the SHA, and it didn't re-download it to re-hash it because I didn't have the SHA, so for me it downloaded. This is a common pitfall.
Please fix up the wrong commit using |
Ah that makes sense. I'll keep that in mind.
Sure, will do after work. |
Hmm, did you change anything else in the last push? Now
|
I've looked through the commits and the only change I can see is the fdm_materials, but I'll do a diff against the old branch to be sure.
Last weekend I was able to run Cura by just building it with nix-build and running the result. I'll have a closer look when I have time (hopefully tonight). |
|
||
disabled = pythonOlder "3.5.0"; | ||
|
||
buildInputs = [ python3 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, thanks!
Please prefix Python packages with |
Done I attempted to figure out what was causing the seg fault, but I'm really out of my depth with this issue. |
@poita66 If you can show that the previous (current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view, the only thing missing here is removing the two lines in the libnest2d
package.
I can also reproduce the segfaults with cura 4.7.0 (it segfaults after exiting). This should be fixed at some point, but not in this PR.
stdenv.mkDerivation rec { | ||
version = "4.8.0"; | ||
pname = "libnest2d"; | ||
format = "other"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format = "other"; |
Please just remove the format = "other"
line.
sha256 = "1hzqi4z55x76rss3xk7hfqhy9hcaq2jaav5jqxa1aqmbvarr2gla"; | ||
}; | ||
|
||
buildInputs = [ python3 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildInputs = [ python3 ]; |
Python is not required to build libnest2d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking those up @gebner! I've applied those changes.
Thanks! |
I've added the new dependencies (pynest2d & libnest2d) but pynest2d won't build because its build target also installs it into python's site_packages folder and I have no idea how to handle that.However, I also wanted to discuss whether switching to an AppImage wrapper might be more appropriate, as that's what Ultimaker's official release is. Ultimaker seem to be a bit lax in their release tagging convention, too, which makes maintaining the package a bit more painful (libnest2d doesn't even have a release tag on the latest version, which is used by pynest2d).Currently I use appimage-run to run Cura 4.8.0 and it runs flawlessly.
Motivation for this change
Ultimaker released a new version of Cura
Closes #103657
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)