netcoredbg: init at 1.2.0-825 #103940
Merged
netcoredbg: init at 1.2.0-825 #103940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking forward to this addition. Great work so far! |
|
I was having some trouble getting it to build with .NET 5. I'm going to try again soon, maybe later today. |
leo60228
force-pushed
the
netcoredbg
branch
3 times, most recently
from
e8246fc
to
18707ef
Compare
|
I've updated this to the latest netcoredbg version, .NET 5, and addressed the review. |
2 tasks
|
You could get the runtime version with something like this, if that's the problem: dotnet --list-runtimes | grep -Po '^Microsoft.NETCore.App \K.*?(?= )' |
|
Updated to latest netcoredbg and improved packaging. |
IvarWithoutBones
requested changes
Oct 26, 2021
|
@ofborg eval |
ofborg
bot
added
ofborg-internal-error
11.by: package-maintainer
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
IvarWithoutBones
requested changes
Oct 31, 2021
IvarWithoutBones
requested changes
Nov 1, 2021
felschr
approved these changes
Nov 4, 2021
IvarWithoutBones
approved these changes
Nov 5, 2021
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
netcoredbg is an open-source debugger for .NET Core applications. The most popular one, vsdbg, is a binary blob distributed with the Visual Studio Code C# extension. However, vsdbg's license is incredibly restrictive. netcoredbg is a drop-in replacement, and is also compatible with other editors.
Note that the package here is... kind of awful. This is both because of the fact that netcoredbg uses CMake in pretty strange ways, and because packaging .NET Core applications in general is pretty bad at the moment.
Closes #103938
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)