Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2020.11.01.1 -> 2020.11.12 #103720

Merged
merged 1 commit into from Nov 16, 2020
Merged

youtube-dl: 2020.11.01.1 -> 2020.11.12 #103720

merged 1 commit into from Nov 16, 2020

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Nov 13, 2020 •
edited

Motivation for this change

New upstream release, fixes youtube playlist download chanegs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
youtube-dl: 2020.11.01.1 -> 2020.11.12
a37c442 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@enolan
Copy link
Contributor

enolan commented Nov 15, 2020

It failed to start when I built it with nix-review :( :

[nix-shell:~/.cache/nixpkgs-review/pr-103720]$ youtube-dl 
Traceback (most recent call last):
  File "/nix/store/z2pcxb2dk4ijj84csbsbdf8i64nh450p-python3.8-youtube-dl-2020.11.12/bin/.youtube-dl-wrapped", line 6, in <module>
    from youtube_dl import main
  File "/nix/store/z7m0kmb43kl6pacw5mmwgbc2qnqhvr8h-python3.7-youtube-dl-2020.11.12/lib/python3.7/site-packages/youtube_dl/__init__.py", line 15, in <module>
    from .options import (
  File "/nix/store/z7m0kmb43kl6pacw5mmwgbc2qnqhvr8h-python3.7-youtube-dl-2020.11.12/lib/python3.7/site-packages/youtube_dl/options.py", line 8, in <module>
    from .downloader.external import list_external_downloaders
  File "/nix/store/z7m0kmb43kl6pacw5mmwgbc2qnqhvr8h-python3.7-youtube-dl-2020.11.12/lib/python3.7/site-packages/youtube_dl/downloader/__init__.py", line 5, in <module>
    from .hls import HlsFD
  File "/nix/store/z7m0kmb43kl6pacw5mmwgbc2qnqhvr8h-python3.7-youtube-dl-2020.11.12/lib/python3.7/site-packages/youtube_dl/downloader/hls.py", line 6, in <module>
    from Crypto.Cipher import AES
  File "/nix/store/724p4lrxql3zn26b4083k1c7n32hx4g3-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Cipher/__init__.py", line 27, in <module>
    from Crypto.Cipher._mode_ecb import _create_ecb_cipher
  File "/nix/store/724p4lrxql3zn26b4083k1c7n32hx4g3-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Cipher/_mode_ecb.py", line 35, in <module>
    raw_ecb_lib = load_pycryptodome_raw_lib("Crypto.Cipher._raw_ecb", """
  File "/nix/store/724p4lrxql3zn26b4083k1c7n32hx4g3-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Util/_raw_api.py", line 308, in load_pycryptodome_raw_lib
    raise OSError("Cannot load native module '%s': %s" % (name, ", ".join(attempts)))
OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying '_raw_ecb.cpython-38-x86_64-linux-gnu.so': /nix/store/724p4lrxql3zn26b4083k1c7n32hx4g3-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-38-x86_64-linux-gnu.so: cannot open shared object file: No such file or directory, Trying '_raw_ecb.abi3.so': /nix/store/724p4lrxql3zn26b4083k1c7n32hx4g3-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so: cannot open shared object file: No such file or directory, Trying '_raw_ecb.so': /nix/store/724p4lrxql3zn26b4083k1c7n32hx4g3-python3.7-pycryptodome-3.9.8/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.so: cannot open shared object file: No such file or directory

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 15, 2020

@enolan I can't reproduce this error: youtube-dl is working fine for me. I tested in a nix-shell and a clean NixOS VM.

@AndersonTorres
Copy link
Member

@enolan is the error persisting?

@enolan
Copy link
Contributor

enolan commented Nov 15, 2020

Yes. I'm running git checkout master&&git pull&& nix-review pr 103720 and then youtube-dl and getting the same error as yesterday. If I check out the PR branch manually and do nix-build . -A youtube-dl&&./result/bin/youtube-dl it works fine though. I'm not sure what nix-review does that gives me a different youtube-dl executable in the PATH.

@ajs124
Copy link
Member

ajs124 commented Nov 15, 2020

This most likely happens in nixpkgs-review, because nix-shell exports PYTHONPATH. So if you run unset PYTHONPATH in the nix-shell before starting it, it should work in there, as well.

@enolan
Copy link
Contributor

enolan commented Nov 15, 2020

Yep, works after unsetting that env var. Should we consider this a bug in nix-review?

@alyssais alyssais merged commit b8065ee into NixOS:master Nov 16, 2020
@Ma27
Copy link
Member

Ma27 commented Nov 16, 2020

@alyssais would you mind taking care of the backport as well? :)

@vdemeester vdemeester deleted the bump-youtube-dl branch November 16, 2020 14:07
@alyssais
Copy link
Member

alyssais commented Nov 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Enzime Enzime Awaiting requested review from Enzime

@Ma27 Ma27 Awaiting requested review from Ma27

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vdemeester @enolan @rnhmjoj @AndersonTorres @ajs124 @Ma27 @alyssais