Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some dead meta.homepage entries #103682

Merged
merged 6 commits into from Nov 26, 2020
Merged

fix some dead meta.homepage entries #103682

merged 6 commits into from Nov 26, 2020

Conversation

evils
Copy link
Member

@evils evils commented Nov 13, 2020

Motivation for this change

i spotted pkgs.elvis.meta.homepage was broken on https://repology.org/repository/nix_unstable/problems
i fixed that and had a quick look through other domain issues on that page

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notes

pg_top gets its source from the same domain as its homepage, and that domain seems to have been recycled by now, it does not have a listed maintainer
i feel like updating its meta.homepage would oblige me to also fix the source and complicate this PR, so i leave that to a future interested party...
openlibm could (should?) be changed to use fetchFromGitHub and the newer repo owner name.

tag @ttuegel, @orivej and @cillianderoiste as they're listed as maintainers for some of the affected packages

@prusnak prusnak merged commit b431a2b into NixOS:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants