Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/codimd: add package option, refactor prettyJSON #103717

Merged
merged 1 commit into from Nov 16, 2020
Merged

nixos/codimd: add package option, refactor prettyJSON #103717

merged 1 commit into from Nov 16, 2020

Conversation

WilliButz
Copy link
Member

This adds a package option to allow for easier overriding of the used
CodiMD version and runCommandLocal with nativeBuildInputs is now
used to pretty print the configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
nixos/codimd: add package option, refactor prettyJSON
74d354a 
This adds a `package` option to allow for easier overriding of the used
CodiMD version and `runCommandLocal` with `nativeBuildInputs` is now
used to pretty print the configuration.
@WilliButz WilliButz requested a review from Ma27 November 13, 2020 15:48
@Ma27 Ma27 merged commit 9fc484c into NixOS:master Nov 16, 2020
@WilliButz WilliButz deleted the codimd/add-package-option branch May 14, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27