Skip to content

plik: init at 1.3.1 #103705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2021
Merged

plik: init at 1.3.1 #103705

merged 3 commits into from
Mar 4, 2021
+181 −0

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Add package, module and test for plik

Currently, the web frontend is extracted from the release from upstream due to problems to
build it. I hope to fix this in a future update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 13, 2020
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 13, 2020
@ofborg ofborg bot requested a review from kalbasit November 13, 2020 14:47
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Nov 13, 2020
aanderse
aanderse requested changes Nov 14, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the module. I'll probably make use of it at some point 👍

I have left a few comments I hope you find helpful. If you have any questions or want any clarification just let me know. Happy to help in any way I can.

nixos/modules/services/misc/plikd.nix
};

config = mkIf cfg.enable {
systemd.services.plikd = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After we merge this PR you might consider contributing this systemd unit to upstream. I'm sure they would benefit from your contribution.

@freezeboy
Copy link
Contributor Author

Thank you for your comments, I tried to fix them, I am still not very sure how to address the "settings" key to have a flexible solution, but not too much hurdle for the admin also

@freezeboy freezeboy changed the title Add plik plik: init at 1.3.1 Nov 29, 2020
@freezeboy
Copy link
Contributor Author

@aanderse, following the example on n8n module, I fixed this one too, and added the hardening config too

aanderse
aanderse approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module LGTM 👍 Unfortunately I don't generally review packages (and know almost nothing about go), so we should get someone else to review this.

@freezeboy freezeboy force-pushed the add-plik branch 2 times, most recently from fdf50ab to 5714411 Compare December 4, 2020 22:48
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/401

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@davidak
Copy link
Member

davidak commented Feb 21, 2021

@freezeboy please rebase.

@freezeboy
plik,plikd: init at 1.3.1
74bec37 
The client and the servers are separated so that a simple user just gets
the necessary binary.

Currently the server frontend has a very old build, I could not build
this asset myself, so for the moment I simply extracted it from the
binary release of the project.

Once this build procedure will have been updated I will transition to a
full build
@freezeboy
nixos/plikd: Add new service module
fc2ae7d
@freezeboy
nixos/tests: new test for plikd
10fa80f
@freezeboy
Copy link
Contributor Author

Conflict resolved

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 23, 2021
@aanderse
Copy link
Member

aanderse commented Mar 4, 2021

@davidak are you familiar enough to merge this?

@davidak
Copy link
Member

davidak commented Mar 4, 2021

Result of nixpkgs-review pr 103705 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
2 packages built:
  • plik
  • plikd

@davidak
Copy link
Member

davidak commented Mar 4, 2021

Result of nixpkgs-review pr 103705 run on x86_64-linux 1

1 test built:
  • nixosTests.plikd

davidak
davidak approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK

Builds and works
Test runs successful

@davidak davidak merged commit 00b4741 into NixOS:master Mar 4, 2021
@freezeboy freezeboy deleted the add-plik branch March 5, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak

@aanderse aanderse

@kalbasit kalbasit

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@freezeboy @nixos-discourse @davidak @aanderse @SuperSandro2000