Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pastebinit: fix basic usage #103716

Merged
merged 1 commit into from Nov 14, 2020
Merged

pastebinit: fix basic usage #103716

merged 1 commit into from Nov 14, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 13, 2020

Motivation for this change

I like piping things from the commandline to a URL for sharing online

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@picnoir
Copy link
Member

picnoir commented Nov 14, 2020

Result of nixpkgs-review pr 103716 1

1 package built:
  • pastebinit

@picnoir picnoir merged commit 07202f8 into NixOS:master Nov 14, 2020
@picnoir
Copy link
Member

picnoir commented Nov 14, 2020

Small nit: it makes the review's job easier when your commit is descriptive.

The PR is small and straightforward here, it's fine :)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @picnoir