Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vte-ng: update patches to apply on vte 0.62 #103704

Merged
merged 1 commit into from Nov 14, 2020
Merged

vte-ng: update patches to apply on vte 0.62 #103704

merged 1 commit into from Nov 14, 2020

Conversation

JJJollyjim
Copy link
Member

Motivation for this change

Closes #103643

The upstream vte-ng patches from 0.56 have applied cleanly up until now, 0.62 added noexcept modifiers everywhere so a modification was necessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JJJollyjim JJJollyjim mentioned this pull request Nov 13, 2020
Merged
1 task
@JJJollyjim
Copy link
Member Author

@ofborg build termite

@asbachb
Copy link
Contributor

asbachb commented Nov 14, 2020

Works for me.

@teto teto merged commit 2ac6d50 into NixOS:master Nov 14, 2020
@jtojnar jtojnar mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbachb asbachb asbachb approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

termite - vte patch fails to apply.
3 participants
@JJJollyjim @asbachb @teto