Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] go_1_14: 1.14.9 -> 1.14.12, go_1_15: 1.15.2 -> 1.15.5 #103719

Merged
merged 6 commits into from Nov 14, 2020
Merged

[20.09] go_1_14: 1.14.9 -> 1.14.12, go_1_15: 1.15.2 -> 1.15.5 #103719

merged 6 commits into from Nov 14, 2020

Conversation

RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 13, 2020 •
edited

(cherry picked from commit 1692a8a)

Motivation for this change

Backports #103649

Go 1.14.12 and 1.15.5 contain a fix for CVE-2020-28362.

Backporting this is a prerequisite for updating vulnerable go packages, such as go-ethereum.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mdlayher
mdlayher approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zowoq
zowoq requested changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cherrypick each version bump.

e.g.
1.14.9 -> 1.14.10
1.14.10 -> 1.14.11
1.14.11 -> 1.14.12

See #97566 an an example.

@zowoq @RaghavSood
go_1_14: 1.14.9 -> 1.14.10
2fe1ee5 
(cherry picked from commit 4f282b1)
@zowoq @RaghavSood
go_1_15: 1.15.2 -> 1.15.3
2915b35 
(cherry picked from commit 6084c2e)
@zowoq @RaghavSood
go_1_14: 1.14.10 -> 1.14.11
166080b 
(cherry picked from commit ffb658f)
@zowoq @RaghavSood
go_1_15: 1.15.3 -> 1.15.4
525dbef 
(cherry picked from commit d1febbe)
@zowoq @RaghavSood
go_1_14: 1.14.11 -> 1.14.12
86d35af 
(cherry picked from commit 1692a8a)
@zowoq @RaghavSood
go_1_15: 1.15.4 -> 1.15.5
93d0659 
(cherry picked from commit a259136)
@ofborg ofborg bot requested a review from mdlayher November 14, 2020 03:12
@RaghavSood RaghavSood changed the title [20.09] go_1_14: 1.14.11 -> 1.14.12, go_1_15: 1.15.4 -> 1.15.5 [20.09] go_1_14: 1.14.9 -> 1.14.12, go_1_15: 1.15.2 -> 1.15.5 Nov 14, 2020
@zowoq zowoq merged commit 808f249 into NixOS:release-20.09 Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlayher mdlayher mdlayher approved these changes

@zowoq zowoq zowoq approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

@Frostman Frostman Awaiting requested review from Frostman

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RaghavSood @mdlayher @zowoq