Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv: fix vapoursynth path #104746

Merged
merged 1 commit into from Nov 24, 2020
Merged

mpv: fix vapoursynth path #104746

merged 1 commit into from Nov 24, 2020

Conversation

CertainLach
Copy link
Contributor

Motivation for this change

MPV fails with [vapoursynth] Could not initialize VapourSynth scripting., because python can't find vapoursynth module because of wrong path being set in wrapper:

export PYTHONPATH='/nix/store/lr6am5dlv3367d0ng4h04w8hpbhcwbvc-vapoursynth-R49/lib/lib/python3.8/site-packages'${PYTHONPATH:+':'}$PYTHONPATH

(Notice /lib/lib in path)

Can be reproduced with

cd ~/.config/mpv
echo > script.vpy
echo "vf=vapoursynth=~~/script.vpy" >> mpv.conf

And then opening any video

This issue is caused by f93918b
In this commit line

      --prefix PYTHONPATH : "${vapoursynth}/lib/${python3.libPrefix}/site-packages:$PYTHONPATH"

was replaced by

       "--prefix" "PYTHONPATH" ":" "${mpv.vapoursynth}/lib/${mpv.vapoursynth.python3.sitePackages}"
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

`mpv.vapoursynth.python3.sitePackages` expands to `/lib/python3.8/site-packages`, thus `/lib/lib/python3.8/site-packages` being produced in wrapper, which is wrong
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I noticed the failure but I didn't have time to debug it.

@rnhmjoj rnhmjoj merged commit 4f165c6 into NixOS:master Nov 24, 2020
@CertainLach CertainLach deleted the patch-1 branch November 24, 2020 13:31
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 24, 2020

Backported to 20.09: 6f92e3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants