Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: fix opening files with pcmanfm #104763

Merged
merged 1 commit into from Nov 24, 2020
Merged

vscode: fix opening files with pcmanfm #104763

merged 1 commit into from Nov 24, 2020

Conversation

hoppla20
Copy link
Contributor

@hoppla20 hoppla20 commented Nov 24, 2020 •
edited

Motivation for this change

My Problem described in #104759

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closes #104759

@teto
Copy link
Member

teto commented Nov 24, 2020

good bug report and nice correction. Impressive for a first contribution. Welcome.

@teto teto merged commit a0f0927 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadwu eadwu eadwu approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCode opens empty file when using PCManFM
4 participants
@hoppla20 @teto @eadwu @Janik-Haag