Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] pythonPackages.pybind11: 2.5.0 -> 2.6.1 #104764

Closed
wants to merge 1 commit into from
Closed

[staging] pythonPackages.pybind11: 2.5.0 -> 2.6.1 #104764

wants to merge 1 commit into from

Conversation

seppeljordan
Copy link
Contributor

Motivation for this change

There is a new version of pybind11 available upstream. Also some packages like e.g. pythonPackages.duckdb require at least version 2.6.0 of this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seppeljordan
Copy link
Contributor Author

seppeljordan commented Nov 24, 2020 •
edited

Ok. I tried to run the nixpkgs-review on this PR but wants to download 20GiB of data an build like 900 packages. Should this go into staging instead of master?

@SuperSandro2000
Copy link
Member

Ok. I tried to run the nixpkgs-review on this PR but wants to download 20GiB of data an build like 900 packages. Should this go into staging instead of master?

Lets wait for ofborg. If he confirms this is a mass rebuild (500+) then it should go through staging.

@seppeljordan
Copy link
Contributor Author

Alright. OfBorg has spoken. I am targeting staging with this PR.

@seppeljordan seppeljordan changed the base branch from master to staging November 24, 2020 12:17
@jonringer jonringer changed the title pythonPackages.pybind11: 2.5.0 -> 2.6.1 [staging] pythonPackages.pybind11: 2.5.0 -> 2.6.1 Nov 24, 2020
@veprbl veprbl added this to WIP in Staging via automation Nov 24, 2020
@veprbl veprbl moved this from WIP to Needs review in Staging Nov 24, 2020
@FRidh
Copy link
Member

FRidh commented Nov 24, 2020

This is already in staging, 346b221.

@FRidh FRidh closed this Nov 24, 2020
Staging automation moved this from Needs review to Done Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seppeljordan @SuperSandro2000 @FRidh