Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/mark-broken: fix path #104751

Merged
merged 1 commit into from Nov 25, 2020
Merged

scripts/mark-broken: fix path #104751

merged 1 commit into from Nov 25, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vikanezrimaya
Copy link
Member

I'm not sure you chose the right branch for the pull request. Please double-check what you're pushing here!

@SuperSandro2000 SuperSandro2000 changed the title nodePackages: add wsl-open scripts/mark-broken: fix path Nov 25, 2020
@SuperSandro2000
Copy link
Member Author

I'm not sure you chose the right branch for the pull request. Please double-check what you're pushing here!

Whoops. Github somehow chose the wrong PR title. Fixed.

vikanezrimaya
vikanezrimaya approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@vikanezrimaya vikanezrimaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is trivial, not breaking anything and seems to be useful. LGTM.

@jonringer jonringer merged commit 0b940b9 into NixOS:master Nov 25, 2020
@SuperSandro2000 SuperSandro2000 deleted the scripts-mark-broken-path branch November 26, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@jonringer jonringer jonringer approved these changes

@vikanezrimaya vikanezrimaya vikanezrimaya approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SuperSandro2000 @vikanezrimaya @lukegb @jonringer