rsync: reproducible #104753
Closed
rsync: reproducible #104753
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the GCC documentation:
I wonder why? |
|
This is a mass rebuild so please target staging. |
|
This feels like a duplication of #102251. |
g++ used for SIMD operations will mangle names. Options are to either disable SIMD, or provide deterministic mangling via -frandom-seed
tomberek
force-pushed
the
tomberek/rsync
branch
from
2065687 to
93ca985
Compare
tomberek
requested review from
cdepillabout,
Ericson2314,
FRidh,
joachifm,
jonringer,
LnL7,
matthewbauer,
Mic92,
thoughtpolice and
zowoq
as code owners
Yes, yes it is. Closing. |
ofborg
bot
added
6.topic: haskell
6.topic: nixos
ofborg
bot
added
8.has: module (update)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g++ used for SIMD operations will mangle names. Options are to either
disable SIMD, or provide deterministic mangling via -frandom-seed
Motivation for this change
https://r13y.com/
@zimbatm
Things done
Found that disabling SIMD provided a reproducible build, but then found that only providing
-frandom-seed=123456provides deterministic name mangling and order in the resulting binary.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)