Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsync: reproducible #104753

Closed
wants to merge 1 commit into from
Closed

rsync: reproducible #104753

wants to merge 1 commit into from

Conversation

tomberek
Copy link
Contributor

g++ used for SIMD operations will mangle names. Options are to either
disable SIMD, or provide deterministic mangling via -frandom-seed

Motivation for this change

https://r13y.com/
@zimbatm

Things done

Found that disabling SIMD provided a reproducible build, but then found that only providing -frandom-seed=123456 provides deterministic name mangling and order in the resulting binary.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Nov 24, 2020

From the GCC documentation:

The string should be different for every file you compile.

I wonder why?

@SuperSandro2000
Copy link
Member

This is a mass rebuild so please target staging.

@SuperSandro2000
Copy link
Member

This feels like a duplication of #102251.

g++ used for SIMD operations will mangle names. Options are to either
disable SIMD, or provide deterministic mangling via -frandom-seed
@tomberek
Copy link
Contributor Author

This feels like a duplication of #102251.

Yes, yes it is. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
R13y
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants