Improve error messages of generate-test-{sxgs,wbns}.sh #26633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 24, 2020
`go get` installs commands in $GOPATH/bin (or ~/go/bin if $GOPATH is not set), which may not be listed in the user's PATH environment variable. crrev.com/c/2556739 updated third_party/blink/web_tests/http/tests/ loading/sxg/resources/generate-test-sxgs.sh, and this updates the remaining scripts and READMEs. Bug: 1151384 Change-Id: I2719fad30d3bb1141fb7abbecb8a2cf1b638a51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557159 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#830883}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2557159
branch
from
e95b69b
to
60ea67a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go getinstalls commands in $GOPATH/bin (or ~/go/bin if $GOPATH is notset), which may not be listed in the user's PATH environment variable.
crrev.com/c/2556739 updated third_party/blink/web_tests/http/tests/
loading/sxg/resources/generate-test-sxgs.sh, and this updates the
remaining scripts and READMEs.
Bug: 1151384
Change-Id: I2719fad30d3bb1141fb7abbecb8a2cf1b638a51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557159
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830883}