Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumpver: init at 2020.1107 + python.pkgs.lexid #104761

Merged
merged 2 commits into from Dec 2, 2020
Merged

bumpver: init at 2020.1107 + python.pkgs.lexid #104761

merged 2 commits into from Dec 2, 2020

Conversation

kfollesdal
Copy link
Contributor

@kfollesdal kfollesdal commented Nov 24, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kfollesdal
Copy link
Contributor Author

Result of nixpkgs-review pr 104761 1

1 package built:
  • pycalver

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104761 run on x86_64-linux 1

1 package built:
  • pycalver

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104761 run on x86_64-darwin 1

1 package built:
  • pycalver

@kfollesdal
Copy link
Contributor Author

Thanks @SuperSandro2000 for good comments. Have now updated with your improvements.

@kfollesdal kfollesdal marked this pull request as draft November 24, 2020 20:38
@kfollesdal
Copy link
Contributor Author

kfollesdal commented Nov 24, 2020 •
edited

@SuperSandro2000, I set this as draft at the moment. Just come out new version with a name change pycalver -> bumpver. I will make the updates tomorrow.

@kfollesdal kfollesdal changed the title pycalver: init at v202010.1043 bumpver: init at 2020.1107 with dependencies python.pkgs.lexid and python.pkgs.lib3to6 Nov 25, 2020
@kfollesdal kfollesdal changed the title bumpver: init at 2020.1107 with dependencies python.pkgs.lexid and python.pkgs.lib3to6 bumpver: init at 2020.1107 + python.pkgs.lexid & python.pkgs.lib3to6 Nov 25, 2020
@kfollesdal kfollesdal changed the title bumpver: init at 2020.1107 + python.pkgs.lexid & python.pkgs.lib3to6 bumpver: init at 2020.1107 + python.pkgs.lexid Nov 25, 2020
@kfollesdal kfollesdal force-pushed the init-pycalver branch 3 times, most recently from f886567 to 94af091 Compare November 25, 2020 20:11
@kfollesdal
Copy link
Contributor Author

Result of nixpkgs-review pr 104761 1

3 packages built:
  • bumpver
  • python37Packages.lexid
  • python38Packages.lexid

@kfollesdal
Copy link
Contributor Author

@SuperSandro2000 I have then got the new version to work. Had to add a missing python dependency lexid.

@kfollesdal kfollesdal marked this pull request as ready for review November 25, 2020 20:16
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104761 run on x86_64-linux 1

3 packages built:
  • bumpver
  • python37Packages.lexid
  • python38Packages.lexid

@kfollesdal kfollesdal force-pushed the init-pycalver branch 2 times, most recently from 23ab43c to cd5ebc4 Compare November 26, 2020 10:13
@kfollesdal
Copy link
Contributor Author

Result of nixpkgs-review pr 104761 1

3 packages built:
  • bumpver
  • python37Packages.lexid
  • python38Packages.lexid

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104761 run on x86_64-linux 1

3 packages built:
  • bumpver
  • python37Packages.lexid
  • python38Packages.lexid

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104761 1

3 packages built:
  • bumpver
  • python37Packages.lexid
  • python38Packages.lexid

SuperSandro2000
SuperSandro2000 requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash the commits into one commit for each package? Thanks.

@kfollesdal
Copy link
Contributor Author

Thanks @SuperSandro2000 for good feedback. Have now squash the commits on to one for each package. I did not do this right away so you easy could see the changes.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104761 run on x86_64-darwin 1

4 packages built:
  • bumpver
  • python37Packages.lexid
  • python38Packages.lexid
  • python39Packages.lexid

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104761 run on x86_64-linux 1

4 packages built:
  • bumpver
  • python37Packages.lexid
  • python38Packages.lexid
  • python39Packages.lexid

@SuperSandro2000 SuperSandro2000 merged commit 4c0b3da into NixOS:master Dec 2, 2020
@kfollesdal kfollesdal deleted the init-pycalver branch December 2, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kfollesdal @SuperSandro2000