linux: explicitly enable RAS #104760
linux: explicitly enable RAS #104760
Conversation
|
ping @lheckemann |
|
@ofborg build linux linux_latest |
| @@ -775,6 +775,8 @@ let | |||
| X86_CHECK_BIOS_CORRUPTION = yes; | |||
| X86_MCE = yes; | |||
|
|
|||
| RAS = yes; | |||
There was a problem hiding this comment.
Maybe add an explicit comment here stating why this is needed?
There was a problem hiding this comment.
Sure I suppose I can do that, though it might be more natural to explicitly enable EDAC as well (as building that really is the intent here, even though the current change is sufficient).
gravndal
changed the title
|
As a sidenote, this should probably be backported to 20.09 if EDAC's missing there as well. Not supporting reporting of low level hardware errors is a bit unfortunate. Edit: Hmm, this doesn't build, thought I checked it yesterday... |
|
I don't think we want EDAC to be built-in to the kernel though — I'd say either go back to enabling only RAS (which can't be modularised), or set EDAC to build as a module explicitly. I think I prefer enabling only RAS. |
|
Seems it can't be modularised if EDAC_GHES is enabled. Looking at some other distros:
Edit: That's for x86_64, it changes a bit with other architectures: E.g. For Fedora on armv7hl ACPI_APEI_GHES is no longer set, and on OpenSUSE *_GHES is left out entirely. |
This is needed for EDAC support.
|
@lheckemann I'm leaving EDAC et al. out of this so at least |
gravndal
changed the title
Motivation for this change
This is needed for EDAC support.
I'm not familiar with how
common-config.nixis structured, so placed the entry near MCE as it is somewhat related.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)