Force the color property at used value time #26604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forced colors should now happen at used value time. This change adds
two internal properties to store the forced colors values of
color and -internal-visited-color. These internal values are then
applied to the visited/unvisited color at used value time when
appropriate.
In addition to color, we also needed to force the used/visited color
value of -webkit-text-fill-color and -webkit-text-stroke-color.
These are forced to currentColor to match the color properties.
This ensures that text color is properly forced in forced colors
mode.
Note: This change will result in some functional differences with the
how colors are inherited in forced colors mode. The related web tests
have been updated to reflect this change in behavior.
Bug: 970285
Change-Id: I8858077397419edc18e89c2b2817788ef42e904b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529950
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Alex Keng <shihken@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#829996}