Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the color property at used value time #26604

Merged
merged 1 commit into from Nov 21, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 21, 2020

Forced colors should now happen at used value time. This change adds
two internal properties to store the forced colors values of
color and -internal-visited-color. These internal values are then
applied to the visited/unvisited color at used value time when
appropriate.

In addition to color, we also needed to force the used/visited color
value of -webkit-text-fill-color and -webkit-text-stroke-color.
These are forced to currentColor to match the color properties.
This ensures that text color is properly forced in forced colors
mode.

Note: This change will result in some functional differences with the
how colors are inherited in forced colors mode. The related web tests
have been updated to reflect this change in behavior.

Bug: 970285
Change-Id: I8858077397419edc18e89c2b2817788ef42e904b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529950
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Alex Keng <shihken@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#829996}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Forced colors should now happen at used value time. This change adds
two internal properties to store the forced colors values of
color and -internal-visited-color. These internal values are then
applied to the visited/unvisited color at used value time when
appropriate.

In addition to color, we also needed to force the used/visited color
value of -webkit-text-fill-color and -webkit-text-stroke-color.
These are forced to currentColor to match the color properties.
This ensures that text color is properly forced in forced colors
mode.

Note: This change will result in some functional differences with the
how colors are inherited in forced colors mode. The related web tests
have been updated to reflect this change in behavior.

Bug: 970285
Change-Id: I8858077397419edc18e89c2b2817788ef42e904b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529950
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Alex Keng <shihken@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#829996}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants