New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tautulli: 2.2.4 -> 2.6.1 #104496
tautulli: 2.2.4 -> 2.6.1 #104496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using nix run nixpkgs.nixpkgs-review -c nixpkgs-review pr 104496
this fails for me with:
[nix-shell:~/.cache/nixpkgs-review/pr-104496]$ tautulli
Cannot write to the data directory: /nix/store/n7cnbn1a3f403aw5jnzkkqh41bpq23jf-Tautulli-2.6.1/libexec/tautulli. Exiting...
I guess the flags |
pkgs/servers/tautulli/default.nix
Outdated
|
||
installPhase = '' | ||
mkdir -p $out | ||
cp -R * $out/ | ||
mkdir -p $out/{bin,libexec/tautulli} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkdir -p $out/{bin,libexec/tautulli} | |
mkdir -p $out/bin $out/libexec/tautulli |
Small nitpick to increase readability.
9303be3
to
946160d
Compare
pkgs/servers/tautulli/default.nix
Outdated
|
||
# Creat backwards compatibility symlink to bin/plexpy | ||
ln -s $out/bin/tautulli $out/bin/plexpy | ||
''; | ||
|
||
checkPase = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkPase = '' | |
checkPhase = '' |
Result of 1 package built:
|
LGTM, with that small nit. |
946160d
to
fdad84f
Compare
Motivation for this change
Upstream update, cleanup of the code to reduce the size of the closure (it contained stuff to build rpm and windows launcher), and migration to python3
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)