Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chroma: 0.8.1 -> 0.8.2 #104494

Merged
merged 1 commit into from Dec 22, 2020
Merged

chroma: 0.8.1 -> 0.8.2 #104494

merged 1 commit into from Dec 22, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

https://github.com/alecthomas/chroma/releases/tag/v0.8.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit November 21, 2020 14:38
markus1189
markus1189 approved these changes Nov 21, 2020
View reviewed changes
Copy link
Contributor

@markus1189 markus1189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chroma --version outputs only ?-?-?, but otherwise seems to work fine

Tested with: nix run nixpkgs.nixpkgs-review -c nixpkgs-review pr 104494

@SuperSandro2000
Copy link
Member

chroma --version outputs only ?-?-?, but otherwise seems to work fine

This should fixed. You probably need to pass in the version at build time.

@sternenseemann
Copy link
Member Author

sternenseemann commented Nov 23, 2020 •
edited

The question mark version is a consequence of the build not using goreleaser which substitutes these values before building a release binary. This issue is also present if you were to use go get to install chroma.

To avoid meddling around with goreleaser which is made for an different purpose than just building a package in a sandbox environment I have now opted to substitute the necessary variables in patchPhase like goreleaser would do.

If you test again you'll see that chroma --version works as expected.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build chroma

@sternenseemann
chroma: 0.8.1 -> 0.8.2
b3aed95 
Populate version information manually to avoid having to integrate
goreleaser into the build process.
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104494 run on x86_64-linux 1

1 package built:
  • chroma

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104494 run on x86_64-darwin 1

1 package built:
  • chroma

@SuperSandro2000 SuperSandro2000 merged commit fe458a9 into NixOS:master Dec 22, 2020
@sternenseemann sternenseemann deleted the chroma-0.8.2 branch December 22, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@markus1189 markus1189 markus1189 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @SuperSandro2000 @markus1189