Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.crytic-compile: fix missing dependency #104493

Merged
merged 1 commit into from Nov 24, 2020

Conversation

arcz
Copy link
Member

@arcz arcz commented Nov 21, 2020

Motivation for this change

crytic-compile uses setuptools as a runtime dependency and fails to run without it:

$ crytic-compile
Traceback (most recent call last):
  File "/nix/store/2v4m2kxrg39307wy4a0w4sdp0biqy222-python3.8-crytic-compile-0.1.9/bin/.crytic-compile-wrapped", line 6, in <module>
    from crytic_compile.__main__ import main
  File "/nix/store/2v4m2kxrg39307wy4a0w4sdp0biqy222-python3.8-crytic-compile-0.1.9/lib/python3.8/site-packages/crytic_compile/__main__.py", line 10, in <module>
    from pkg_resources import require
ModuleNotFoundError: No module named 'pkg_resources'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Nov 24, 2020

Result of nixpkgs-review pr 104493 1

4 packages built:
  • python37Packages.crytic-compile
  • python37Packages.slither-analyzer
  • python38Packages.crytic-compile
  • slither-analyzer (python38Packages.slither-analyzer)

@ryantm ryantm merged commit b160b93 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants