Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: 1.47 -> 1.48 #104492

Closed
wants to merge 1 commit into from
Closed

rust: 1.47 -> 1.48 #104492

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2020 •
edited by ghost

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from LnL7, Mic92 and zowoq as code owners November 21, 2020 14:16
@zowoq
Copy link
Contributor

zowoq commented Nov 21, 2020

Built fd on x86_64-darwin.

@turboMaCk
Copy link
Member

turboMaCk commented Nov 23, 2020 •
edited

(it took a while but) I was able to build rustc on nixos on this branch as well. I haven't tried to find & compile things depending on it though.

@Mic92
Copy link
Member

Mic92 commented Nov 23, 2020

I started nix-review pr -p firefox 104492. I don't have my fancy server right now, so it might take a bit.

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2020

Result of nixpkgs-review pr 104492 1

1 package built:
  • thunderbird

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2020

Firefox was not rebuild but thunderbird.

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2020

Cherry picked in 9eb79c4

@Mic92 Mic92 closed this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @turboMaCk @Mic92