Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the Poisson series basis generator #2790

Merged
merged 12 commits into from
Nov 22, 2020
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Nov 21, 2020

In particular, this avoids the ugliness around dimensions and the stupid sort.

#2400.

// values in a Hilbert space with |dimension| dimensions.
template<typename Polynomial, int dimension>
struct PolynomialGenerator {
// Returns a polynomial whose dimension and degree are encoded in |index|.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/dimension/coordinate/, using "dimension" in both the "nth dimension" and "number of dimensions" sense is confusing.

Same everywhere else (including in the comments).

@eggrobin eggrobin added the LGTM label Nov 21, 2020
@pleroy pleroy merged commit a3ff357 into mockingbirdnest:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants