Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cachix: Fix building on hydra and reenable #104503

Merged
merged 2 commits into from Nov 21, 2020

Conversation

maralorn
Copy link
Member

Motivation for this change

We want to fix #104475 and keep cachix working.

@domenkozar is that okay for you (for now) or did you have something different in mind?

\cc @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn maralorn changed the title Enable cachix cachix: Fix building on hydra and reenable Nov 21, 2020
@maralorn
Copy link
Member Author

@turboMaCk You said in #103740 (comment), that haskell.packages.ghc883.cachix builds for you. Though are you sure about that? On current master this fails with a failure to build repline 0.4.0.0 for me.

I might be confusing something there …
Will look into it further.

@turboMaCk
Copy link
Member

turboMaCk commented Nov 21, 2020

To clarify yesterday (during the stream) I just tried to pull haskell-updates branch locally and run nix-build. I no longer had the result though because I garbage collected it :/

Anyway I tried to pull this PR and test the build. It also no longer works for me. There is a failure in configure phase for repline-0.4.0.0.. - missing dependency for haskeline ==0.8.*.

Perhaps I did too sloppy job testing it yesterday. Maybe some of the commits were not pushed yet at the point when I pulled. I just switch to it for a second since I was primarily working on something else.

Feel free to ping me if you need a help with this. I'm turbo_MaCk#7903 on Discord and turbo_MaCk on IRC.

@turboMaCk
Copy link
Member

turboMaCk commented Nov 21, 2020

Also be aware that @domenkozar is working on 8.10 support in this branch PR cachix/cachix#331 I think his preferred approach is to fix it in upstream right away rather than risking doing more work by both patching & then fixing the upstream.

@maralorn
Copy link
Member Author

I have this PR working locally and will push it after a bit of clean-up in a few minutes.

This removes the broken flag from everything depending on servant so it
can get a new chance to build following the servant fix.
@maralorn
Copy link
Member Author

I think having a few servant- packages without a broken flag is a bearable problem. I will merge master into haskell-updates, when this is merged and we'll continue curating the package set there.

@domenkozar This built for me locally. I suggest you press merge, if you want.

@turboMaCk
Copy link
Member

👍 one for switching to patch for ghc 8.10. I was also able to build this locally.

@domenkozar
Copy link
Member

domenkozar commented Nov 21, 2020

@maralorn I really appreciate your effort and help getting this fixed ❤️

@domenkozar domenkozar merged commit 7886d7c into NixOS:master Nov 21, 2020
@maralorn maralorn deleted the enable-cachix branch November 21, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation error on master related to Cachix
3 participants