Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezord: 2.0.29 -> 2.0.30 #103222

Merged
merged 1 commit into from Nov 9, 2020
Merged

trezord: 2.0.29 -> 2.0.30 #103222

merged 1 commit into from Nov 9, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 9, 2020 •
edited

Motivation for this change

Version update, switch to Go modules

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@1000101
Copy link
Member

1000101 commented Nov 9, 2020

@GrahamcOfBorg build trezord

1000101
1000101 approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@1000101 1000101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with device.

@mmahut mmahut merged commit c4229ff into NixOS:master Nov 9, 2020
@prusnak prusnak deleted the trezord branch November 10, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@1000101 1000101 1000101 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@canndrew canndrew Awaiting requested review from canndrew

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @1000101 @jb55 @mmahut