Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailutils: update guile to current version #103209

Merged
merged 1 commit into from Nov 17, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 9, 2020

Motivation for this change

Apparently a previous version of mailutils didn't compile
with guile 2.2, but this does no longer appear to be the case.

This is particularly relevant because mailutils is part of
the iso_minimal test set we are currently focusing on for
getting more of NixOS reproducible, and guile_2_0 is not
reproducible (https://r13y.com/)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Apparently a previous version of mailutils didn't compile
with guile 2.2, but this does no longer appear to be the case.

This is particularly relevant because mailutils is part of
the iso_minimal test set we are currently focusing on for
getting more of NixOS reproducible, and guile_2_0 is not
reproducible (https://r13y.com/)
@raboof raboof changed the base branch from master to staging November 9, 2020 14:23
@andir andir self-assigned this Nov 9, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103209 run on x86_64-darwin 1

5 packages marked as broken and skipped:
  • haskellPackages.libzfs
  • logrotate
  • mailutils
  • sanoid
  • smartmontools

@zimbatm
Copy link
Member

zimbatm commented Nov 11, 2020

Result of nixpkgs-review pr 103209 1

7 packages marked as broken and skipped:
  • bareos
  • linuxPackages_hardkernel_4_14.zfs
  • linuxPackages_hardkernel_4_14.zfsStable
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfs
  • linuxPackages_hardkernel_latest.zfsStable
  • linuxPackages_hardkernel_latest.zfsUnstable
1 package blacklisted:
  • tests.nixos-functions.nixosTest-test
92 packages failed to build:
  • automysqlbackup
  • ceph (ceph-dev)
  • ceph-client
  • collectd
  • collectd-data
  • docker-machine-kvm
  • docker-machine-kvm2
  • easysnap
  • gnome3.gnome-boxes
  • grub2 (grub2_full)
  • grub2_efi
  • grub2_pvgrub_image
  • grub2_xen
  • gsmartcontrol
  • haskellPackages.libvirt-hs
  • haskellPackages.libzfs
  • libceph
  • libguestfs
  • libvirt
  • libvirt-glib
  • libvirt_5_9_0
  • libvmi
  • linuxPackages-libre.zfs (linuxPackages-libre.zfsStable)
  • linuxPackages-libre.zfsUnstable
  • linuxPackages.zfs (linuxPackages.zfsStable ,linuxPackages_5_4.zfs ,linuxPackages_5_4.zfsStable)
  • linuxPackages.zfsUnstable (linuxPackages_5_4.zfsUnstable)
  • linuxPackages_4_14.zfs (linuxPackages_4_14.zfsStable)
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_4_19.zfs (linuxPackages_4_19.zfsStable)
  • linuxPackages_4_19.zfsUnstable
  • linuxPackages_4_4.zfs (linuxPackages_4_4.zfsStable)
  • linuxPackages_4_4.zfsUnstable
  • linuxPackages_4_9.zfs (linuxPackages_4_9.zfsStable)
  • linuxPackages_4_9.zfsUnstable
  • linuxPackages_5_8.zfs (linuxPackages_5_8.zfsStable)
  • linuxPackages_5_8.zfsUnstable
  • linuxPackages_5_9.zfs (linuxPackages_5_9.zfsStable ,linuxPackages_latest.zfs ,linuxPackages_latest.zfsStable)
  • linuxPackages_5_9.zfsUnstable (linuxPackages_latest.zfsUnstable)
  • linuxPackages_hardened.zfs (linuxPackages_hardened.zfsStable)
  • linuxPackages_hardened.zfsUnstable
  • linuxPackages_latest-libre.zfs (linuxPackages_latest-libre.zfsStable)
  • linuxPackages_latest-libre.zfsUnstable
  • linuxPackages_latest_hardened.zfs (linuxPackages_latest_hardened.zfsStable)
  • linuxPackages_latest_hardened.zfsUnstable
  • linuxPackages_latest_xen_dom0.zfs (linuxPackages_latest_xen_dom0.zfsStable)
  • linuxPackages_latest_xen_dom0.zfsUnstable
  • linuxPackages_latest_xen_dom0_hardened.zfs (linuxPackages_latest_xen_dom0_hardened.zfsStable)
  • linuxPackages_latest_xen_dom0_hardened.zfsUnstable
  • linuxPackages_testing_bcachefs.zfs (linuxPackages_testing_bcachefs.zfsStable)
  • linuxPackages_testing_bcachefs.zfsUnstable
  • linuxPackages_xen_dom0.zfs (linuxPackages_xen_dom0.zfsStable)
  • linuxPackages_xen_dom0.zfsUnstable
  • linuxPackages_xen_dom0_hardened.zfs (linuxPackages_xen_dom0_hardened.zfsStable)
  • linuxPackages_xen_dom0_hardened.zfsUnstable
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable)
  • linuxPackages_zen.zfsUnstable
  • logrotate
  • mailutils
  • minikube
  • minishift
  • nixops
  • nixopsUnstable
  • nixops_1_6_1
  • os-prober
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python27Packages.guestfs
  • python27Packages.libvirt
  • python37Packages.guestfs
  • python37Packages.libvirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
  • rubyPackages_2_5.ruby-libvirt
  • rubyPackages_2_7.ruby-libvirt
  • sambaFull (samba4Full)
  • sanoid
  • smartmontools
  • terraform-full
  • terraform-providers.libvirt
  • terraform_0_11-full
  • terragrunt
  • tlp
  • vagrant
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst
  • zfs (zfsStable)
  • zfsUnstable
  • zfstools

@raboof
Copy link
Member Author

raboof commented Nov 13, 2020

92 packages failed to build:

  • automysqlbackup
    ...

Thanks! I'm not too familiar with nixpkgs-review so I might need some hand-holding here.

nixpkgs-review pr -p automysqlbackup 103209 succeeds for me, now. Could that be because it was a transient error, or because staging moved since?

@raboof
Copy link
Member Author

raboof commented Nov 13, 2020

ceph ceph-client

These are failing due to #101636 (comment)

automysqlbackup collectd collectd-data docker-machine-kvm docker-machine-kvm2 easysnap gnome3.gnome-boxes grub2 grub2_efi grub2_pvgrub_image grub2_xen gsmartcontrol

These currently nixpkgs-review successfully for me. (did not build the rest yet)

@zimbatm
Copy link
Member

zimbatm commented Nov 17, 2020

I think you are right, nixpkgs-review was using a broken version of staging. I was able to build nixos/tests/login.nix so I think it's good to merge.

@zimbatm zimbatm merged commit 2d9839d into NixOS:staging Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants